Repository navigation
fix(cli): reject unknown regions and separate app lists - #306
autoidm-jon wants to merge 8 commits into
Conversation
|
PR tier:
A changed diff is scored again. Job log: https://github.com/AutoIDM/pdt/actions/runs/41703475276 |
|
Reviewer: Cursor Goal: pdt commands show app lists apart from the next-step hints, write a place as provider (region), and suggest a region the same way in every command that asks for one.
The reviewer also found no provider-and-region text left in the comma form in source, tests, or docs. Checks that passed on 55b64e6: |
|
PR tier:
A changed diff is scored again. Job log: https://github.com/AutoIDM/pdt/actions/runs/41867267251 |
|
Output changes from Places print as provider (region)Commands run: -1 alpha azure, region eastus2, subscription sub-1, resource group pdt
+1 alpha azure (eastus2, subscription sub-1, resource group pdt)
- own google-cloud, region us-east4; edit own/config.yml to move it
+ own google-cloud (us-east4); edit own/config.yml to move it-alpha is deployed to azure, region eastus2, subscription sub-1, resource group pdt,
-but pdt.yml now deploys it to aws, region us-east-2.
+alpha is deployed to azure (eastus2, subscription sub-1, resource group pdt),
+but pdt.yml now deploys it to aws (us-east-2).
|
Every next-steps block and the help line after a failure start after a blank line. The region questions of pdt init print the suggestion and its reason, as the first deploy does.
Port the region check of PR 206: `regions.REGIONS` and `region_problem` in `validate_app`, the first-deploy question, and the `pdt init` question. Also remove the suggestion and region-list lines above the `pdt init` region question.
55b64e6 to
42bcaa5
Compare
|
Before and after output:
A wrong region in the
|
|
Goal: a wrong region stops The code review ran in four rounds. The last round, on 42bcaa5, found no blocker and no should-fix.
Open decisions:
|
|
PR tier:
A changed diff is scored again. Job log: https://github.com/AutoIDM/pdt/actions/runs/42046260303 |
A region that the provider does not have is now an error in
pdt init,pdt validate, andpdt deploy, before any cloud call, with the closest real names, and each deploy config error names the app once. A blank line now separates each app list and each next-steps block from the text around it, and places print asazure (eastus2).