Repository navigation
Add Text Rules for incoming messages - #485
Merged
Merged
Conversation
- Filter channel, DM, and room messages using local rules. - Keep matches in Recently Blocked for review. - Handle missed room posts and interrupted radio cleanup.
# Conflicts: # MC1/State/MessageEventDispatcher.swift # MC1/Views/RemoteNodes/Rooms/RoomConversationView.swift # MC1/Views/Settings/Sections/DangerZoneViewModel.swift # MC1/Views/Settings/SettingsSubpage.swift # MC1Services/Sources/MC1Services/Connection/ConnectionManager+Lifecycle.swift # MC1Services/Sources/MC1Services/Connection/ConnectionManager+Pairing.swift # MC1Services/Sources/MC1Services/Connection/ConnectionManager.swift # MC1Services/Sources/MC1Services/ServiceContainer.swift # MC1Services/Sources/MC1Services/Services/AdvertisementService.swift # MC1Services/Sources/MC1Services/Services/MessagePollingService.swift # MC1Services/Sources/MC1Services/Services/PersistenceStore+Devices.swift # MC1Services/Sources/MC1Services/Services/PersistenceStore.swift # MC1Services/Sources/MC1Services/Services/RemoteNodeService+Login.swift # MC1Services/Sources/MC1Services/Services/RoomServerService.swift # MC1Services/Sources/MC1Services/Services/RxLogService.swift # MC1Services/Sources/MC1Services/Sync/SyncCoordinator+MessageHandlers.swift # MC1Services/Tests/MC1ServicesTests/ConnectionManagerPairingTests.swift # MC1Services/Tests/MC1ServicesTests/Mocks/MockAccessorySetupKitService.swift
- Require a receive scope through delivery so each layer can reject stale work. - Save rules directly and update DTO copies to avoid rebuilding records. - Verify that Text Rules settings stay out of backups and remove duplicate test cases.
# Conflicts: # MC1Services/Tests/MC1ServicesTests/Helpers/ConnectionRadioHandoffHarness.swift
A space after the last word was stored with the phrase and then failed to match.
- Name the message, rule, sender, chat, node, and time on each hidden message. - Describe the matched rule with the summary the rules list already uses. - Translate the new labels for the other locales.
Avi0n
marked this pull request as ready for review
November 6, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
People receiving repeated spam had to block individual senders. Text Rules lets them filter an incoming message by its text or sender name and choose which channel, DM, or room conversations the rules apply to. Related to #483.
Overview of Changes
Testing
Try it with demo data. In Settings → Chats → Blocking → Text Rules, add a message rule that contains
demo spam. Enable it for one channel and leave another channel off. Send the same text to both. The enabled channel's message should appear only in Recently Blocked with the matching phrase underlined. The other message should appear in its conversation. Repeat with a message queued while disconnected.Regression evidence
ERR_CODE_TABLE_FULLDetails
Rules, conversation overrides, and Recently Blocked entries are stored locally. Recently Blocked entries are excluded from shareable backups. Channel slot reuse follows existing stock delivery behavior.
ELI5
Choose the words or sender names you want to filter and where the rules apply. Matching messages go to a separate list you can check later.