Repository navigation
Use device localisation for temperature/distance/pressure units - #488
Merged
Merged
Conversation
|
Hi @neilalexander, thanks for the contribution! This PR is being closed automatically because the required checklist items are not checked:
Please verify you have completed these items, then check the corresponding boxes in the PR description (the checklist has been added there for you). The PR will reopen automatically once the above are addressed. |
|
All required checklist items are now checked, reopening. Thanks @neilalexander! |
Owner
|
Awesome, thanks!! |
Owner
|
Before I merge this, could you rebase onto current dev? And to satisfy SwiftFormat, remove the |
neilalexander
force-pushed
the
neil/temperatures
branch
from
November 10, 2026 09:55
63ac495 to
e7b2a85
Compare
Contributor
Author
|
Rebased & formatter happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all locales are binary metric or imperial, the UK for example uses celsius for temperatures but miles for distances and therefore doesn't match
.metric(there's.ukfor our unique way of doing things), so UK users were shown ºF incorrectly in all cases. Instead just always use the device locale to tell us which units to use, that way we shouldn't ever get it wrong.Tested on
Checklist
CONTRIBUTING.md