Repository navigation
fix: decode MECP with the top-level 1.4.0 message pattern - #495
Merged
Merged
Conversation
- Reject a bunch of formatting failures that the spec defines as 'not MECP'. - Strip a trailing newline on decode. - Free text is returned unmodified, so runs of spaces are no longer collapsed. First commit in a series for issue Avi0n#494
Blake-Latchford
marked this pull request as ready for review
November 19, 2026 19:00
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First PR in a series for #494, covering its first three sections. MC1's decoder now uses the MECP 1.4.0 §6.1 message pattern, so strings the spec defines as not MECP stay plain text and MECP read from a serial or text source keeps its codes.
Overview of Changes
MECPDecode.decodereplaces the token scan with one regex, matched by Unicode scalar so that a CRLF is two scalars, as it is in other languages. Callers that getnilalready show the raw text, so a rejected string still appears in the chat as plain text.Testing
MECPDecodeTestscovers each example in MECP 1.4.0 Support #494's first three sections, plus tabs, a non-breaking space, a code-shaped word that is not a whole code, every Unicode line break, and repeated trailing line endings.swift testin theswift:6.2Docker image on Linux. All decode tests pass. The one failure ispack choice uses the first preferred localization, which fails on Linux before any MECP code runs because Linux Foundation resolveszh-Hanstoen. It is unrelated to this change.swiftlint lintis clean on both changed files.I don't have access to an Apple device on which to test my code. However, I have tested the unit tests on linux/docker with the command below.
Tested on
Checklist
CONTRIBUTING.md🤖 Generated with Claude Code