Skip to content

fix: Expand MECP person count matches per MECPv1.4.0 - #496

Merged
Avi0n merged 2 commits into
Avi0n:devfrom
Blake-Latchford:fix/mecp-person-count
Nov 20, 2026
Merged

Avi0n merged 2 commits into
Avi0n:devfrom
Blake-Latchford:fix/mecp-person-count

Conversation

@Blake-Latchford

Copy link
Copy Markdown

Description

Second commit in a series for issue #494

Testing

  • MECPDecodeTests covers each example in MECP 1.4.0 Support #494's person count section, plus a non-breaking space, a thin space, curly quotes, a vertical tab, a count without boundaries followed by a valid one, and a count too large for Int.
  • Ran the MECP decode and catalog tests with swift test in the swift:6.2 Docker image on Linux. All decode tests pass. The one failure is pack choice uses the first preferred localization, which fails on Linux before any MECP code runs because Linux Foundation resolves zh-Hans to en. It is unrelated to this change.
  • swiftlint lint is clean on both changed files.

I don't have access to an Apple device on which to test my code. However, I have tested the unit tests on linux/docker with the command below.

docker run --rm --user "$(id -u):$(id -g)" -e HOME=/tmp \
  -v "$REPO":"$REPO":ro -v "$HERE":"$HERE" -w "$HERE" \
  swift:6.2 swift test "$@"

Tested on

  • iOS [version]
  • iPadOS [version]
  • macOS [version]

Checklist

  • This PR was discussed with the maintainer either via GitHub issue or other means (Also check the box if this PR is small enough not to need discussion e.g. typo fix)
  • I have read CONTRIBUTING.md
  • Testing steps are documented above.
  • This change is not low effort and I took the time to test it

🤖 Generated with Claude Code

Second commit in a series for issue Avi0n#494
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Blake-Latchford
Blake-Latchford marked this pull request as ready for review November 20, 2026 02:34
@Avi0n

Avi0n commented Nov 20, 2026

Copy link
Copy Markdown
Owner

LGTM, thanks!

@Avi0n
Avi0n merged commit 059bc16 into Avi0n:dev Nov 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants