Skip to content

rvf: Fix user defined frame rate constant - #50

Open
edersondisouza wants to merge 1 commit into
Avnu:masterfrom
edersondisouza:fix-rvf-user-frame-rate
Open

edersondisouza wants to merge 1 commit into
Avnu:masterfrom
edersondisouza:fix-rvf-user-frame-rate

Conversation

@edersondisouza

Copy link
Copy Markdown
Collaborator

There's a typo on the 2016 version of IEEE 1722, fixed on 2025 one. Table 42 shows that last value of the octet is the user defined one, so 0xFF (or FF16, depending on notation). But it's written as F16, which is in conflict with the range from 4 to F16 stated as reserved previously. This patch changes the constant to 0xFF.

Fixes #49

@edersondisouza
edersondisouza requested a lite review from Copilot September 15, 2026 17:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@edersondisouza
edersondisouza requested a lite review from Copilot September 15, 2026 17:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

There's a typo on the 2016 version of IEEE 1722, fixed on 2025 one.
Table 42 shows that last value of the octet is the user defined one, so
0xFF (or FF16, depending on notation). But it's written as F16, which is
in conflict with the range from 4 to F16 stated as reserved previously.
This patch changes the constant to 0xFF.

Fixes Avnu#49

Signed-off-by: Ederson de Souza <ederson.desouza@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frame rate user in RVF incorrectly defined

2 participants