Repository navigation
Upgrade MCP SDK to 2.2.0 and tie location subscriptions to the session lifetime - #231
Merged
Merged
Conversation
…ions Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
…h-newer-mcp Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
…race Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Mike Krüger (mkrueger)
October 1, 2026 09:36
View session
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Mike Krüger (mkrueger)
marked this pull request as ready for review
October 1, 2026 13:16
Mike Krüger (mkrueger)
requested review from
a team
and
a balanced review from Copilot
October 1, 2026 13:16
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the SDK lifecycle model and includes focused regression coverage and documentation.
Review effort: Balanced
Findings: None
What changed in this PR
Upgrades the MCP SDK while preserving stateful behavior and tying location subscriptions to session lifetimes.
Changes:
- Upgrades MCP packages to 2.2.0 and explicitly enables stateful sessions.
- Cleans subscriptions up on session termination.
- Adds lifecycle regression tests, race-free test ports, and timeout documentation.
| File | Description |
|---|---|
Directory.Packages.props |
Upgrades MCP SDK packages. |
McpServer.cs |
Configures stateful sessions and timeout cleanup. |
LocationResourceSubscriptions.cs |
Tracks subscriptions by session lifetime. |
ToolOperations.cs |
Uses session IDs for subscriptions. |
McpLocationSubscriptionTests.cs |
Tests GC resilience, cleanup, and transport settings. |
docs/mcp.md |
Documents subscription expiration behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vsevolod Kukol (sevoku)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated MCP SDK to 2.2.0