Repository navigation
Stop advertising static MCP resource list changes - #242
Merged
Mike Krüger (mkrueger) merged 1 commit intoOct 8, 2026
Merged
Mike Krüger (mkrueger) merged 1 commit into
Mike Krüger (mkrueger) merged 1 commit into
Conversation
Register static resource handlers while preserving location subscriptions and resource metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mike Krüger (mkrueger)
requested review from
a team
and
a balanced review from Copilot
October 8, 2026 09:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, documentation, and focused tests consistently enforce the intended static resource-list contract.
0 open findings
What changed in this PR
Replaces dynamic MCP resource registration with static handlers so the server no longer advertises resource-list changes while preserving resource reads and content subscriptions.
Changes:
- Adds static resource list/read handlers with protocol-specific errors.
- Disables
resources.listChangedand expands subscription tests. - Documents the static resource-list behavior.
| File | Description |
|---|---|
README.md |
Clarifies static resource capabilities. |
docs/mcp.md |
Documents supported subscription behavior. |
ResourceOperations.cs |
Implements static resource handlers. |
McpServer.cs |
Registers handlers and disables list-change capability. |
McpLocationSubscriptionTests.cs |
Covers capabilities, resources, errors, and filters. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Vsevolod Kukol (sevoku)
approved these changes
Oct 8, 2026
Mike Krüger (mkrueger)
deleted the
dev/mkrueger/fix-static-mcp-resource-capabilities
branch
October 8, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The resource list is static, but the MCP SDK advertises
resources.listChangedwhenever a resource collection is registered. This contradicts the custom subscription handler, which intentionally rejects list-change filters.resources.listChangedwhile retaining current-location content subscriptions.Independent fix based on
main; does not include or modify the stdio work in #239.Validation
McpLocationSubscriptionTestspassed.