Skip to content

Hotfix: Key Vault challenge cache validation (secrets 4.11.2) - #48741

Merged
ROHIT SINGHAL (rohitsinghal4u) merged 1 commit into
hotfix/keyvault-secretsfrom
hotfix/keyvault-secrets-fix
Aug 25, 2026
Merged

Hotfix: Key Vault challenge cache validation (secrets 4.11.2)#48741
ROHIT SINGHAL (rohitsinghal4u) merged 1 commit into
hotfix/keyvault-secretsfrom
hotfix/keyvault-secrets-fix

Conversation

@rohitsinghal4u

Copy link
Copy Markdown
Contributor

Summary

Security hotfix backporting the Key Vault challenge-cache-after-validation fix (MSRC / ICM 31000000679759) to azure-keyvault-secrets 4.11.1 -> 4.11.2, per the hotfix policy. Targets the hotfix/keyvault-secrets branch (created from the azure-keyvault-secrets_4.11.1 tag).

The challenge is now cached only after the challenge resource is verified, in both the sync and async policies (the async policy previously relied on the shared helper to cache), so a rejected challenge is not cached and reused by later requests.

Changes

  • Remove the cache write from the shared _update_challenge helper.
  • Add the post-verification cache write to the sync and async on_challenge.
  • Bump to 4.11.2 + CHANGELOG entry.

Tests

pytest test_challenge_auth.py test_challenge_auth_async.py -> 4 passed. Cache-after-verify and async-cache placement verified. The identical fix is in main via #48710.

Backports the challenge-cache-after-validation security fix (MSRC / ICM 31000000679759) to released azure-keyvault-secrets 4.11.1. Caches the challenge only after the challenge resource is verified in both the sync and async policies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@rohitsinghal4u
ROHIT SINGHAL (rohitsinghal4u) merged commit 5c95cf1 into hotfix/keyvault-secrets Aug 25, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure SDK for Key Vault Aug 25, 2026
@rohitsinghal4u
ROHIT SINGHAL (rohitsinghal4u) deleted the hotfix/keyvault-secrets-fix branch August 25, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant