fix: avoid status update conflicts during credential retries - #160
Open
John Stupka (hunter32292) wants to merge 3 commits into
Open
John Stupka (hunter32292) wants to merge 3 commits into
John Stupka (hunter32292) wants to merge 3 commits into
Conversation
Treat credential errors that differ only by ACR correlation ID as equivalent so retries do not continuously rewrite binding status. Preserve full-object E2E updates while retrying conflicts from freshly fetched resources. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
John Stupka (hunter32292)
marked this pull request as ready for review
October 1, 2026 16:35
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat credential errors that differ only by ACR correlation ID as equivalent so retries do not continuously rewrite binding status. Preserve full-object E2E updates while retrying conflicts from freshly fetched resources.
Seeing the retries on that e2e be sad: https://github.com/Azure/msi-acrpull/actions/runs/36583994055/job/110436562749?pr=159