Repository navigation
Add CRUD workload timing - #1338
Conversation
|
For reviewers only: reply |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Job metadata is mislabeled and temporary pipeline validation configuration remains committed.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds aggregate timing and failure reporting for Azure Kubernetes workload CRUD operations.
Changes:
- Records aggregate Deployment, StatefulSet, and Job timing metadata.
- Preserves explicit operation failures and expands result tests.
- Updates CRUD documentation and temporary pipeline validation.
| File | Description |
|---|---|
pipelines/system/new-pipeline-test.yml |
Adds temporary workload timing validation. |
modules/python/tests/crud/test_operation.py |
Tests explicit failure preservation. |
modules/python/tests/crud/test_main.py |
Tests workload result collection. |
modules/python/tests/crud/test_azure_node_pool_crud.py |
Verifies aggregate timing records. |
modules/python/crud/README.md |
Documents workload commands and module invocation. |
modules/python/crud/operation.py |
Preserves explicitly assigned failure status. |
modules/python/crud/azure/node_pool_crud.py |
Records aggregate workload operation results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/run-tf-integration |
1 similar comment
|
/run-tf-integration |
Leonard Du (LeonardCareer)
left a comment
There was a problem hiding this comment.
lgtm
|
The failed check is caused by a pre-existing CI bug in empty Terraform plan matrix handling. The Terraform tests passed, and this PR has no Terraform-related changes. I’ll fix the workflow separately. This PR is OK to merge. |

Summary
results.json.python3 -m crud.main.Timing contract
create_pods,create_statefulset, andcreate_jobs.Validation
test_operation.py: 27 tests passedtest_azure_node_pool_crud.py: 24 tests passedtest_main.py: 57 tests passedgit diff --check: cleanPipeline validation
62c44efeb.