Skip to content

Add CRUD workload timing - #1338

Merged
Diamond (diamondpowell) merged 4 commits into
mainfrom
dipowell/crud-workload-timing
Oct 5, 2026
Merged

Diamond (diamondpowell) merged 4 commits into
mainfrom
dipowell/crud-workload-timing

Conversation

@diamondpowell

Copy link
Copy Markdown
Contributor

Summary

  • Record one aggregate timing result for each Azure Deployment, StatefulSet, and Job command.
  • Preserve explicit failure status when one or more workload instances fail.
  • Verify workload timing records are collected into results.json.
  • Update CRUD examples to use python3 -m crud.main.

Timing contract

  • Operation names remain create_pods, create_statefulset, and create_jobs.
  • Each CLI command emits one aggregate row across all requested workload instances.
  • Metadata includes workload type, node pool, requested count, replicas or completions, namespace, and successful workload count.

Validation

  • test_operation.py: 27 tests passed
  • test_azure_node_pool_crud.py: 24 tests passed
  • test_main.py: 57 tests passed
  • Pylint: 10.00/10
  • git diff --check: clean

Pipeline validation

  • Temporary validation configuration is isolated in commit 62c44efeb.
  • End-to-end workload timing validation is pending.
  • The temporary pipeline commit will be removed before the PR is marked ready for review.

@github-actions

Copy link
Copy Markdown

For reviewers only: reply /run-tf-integration to trigger the terraform integration pipeline before approving the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Job metadata is mislabeled and temporary pipeline validation configuration remains committed.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds aggregate timing and failure reporting for Azure Kubernetes workload CRUD operations.

Changes:

  • Records aggregate Deployment, StatefulSet, and Job timing metadata.
  • Preserves explicit operation failures and expands result tests.
  • Updates CRUD documentation and temporary pipeline validation.
File Description
pipelines/​system/​new-pipeline-test.yml Adds temporary workload timing validation.
modules/​python/​tests/​crud/​test_operation.py Tests explicit failure preservation.
modules/​python/​tests/​crud/​test_main.py Tests workload result collection.
modules/​python/​tests/​crud/​test_azure_node_pool_crud.py Verifies aggregate timing records.
modules/​python/​crud/​README.md Documents workload commands and module invocation.
modules/​python/​crud/​operation.py Preserves explicitly assigned failure status.
modules/​python/​crud/​azure/​node_pool_crud.py Records aggregate workload operation results.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pipelines/system/new-pipeline-test.yml Resolved
@diamondpowell Diamond (diamondpowell) changed the title Add aggregate CRUD workload timing Add CRUD workload timing Sep 30, 2026
@LeonardCareer

Copy link
Copy Markdown
Collaborator

/run-tf-integration

1 similar comment
@LeonardCareer

Copy link
Copy Markdown
Collaborator

/run-tf-integration

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeonardCareer

Copy link
Copy Markdown
Collaborator

The failed check is caused by a pre-existing CI bug in empty Terraform plan matrix handling. The Terraform tests passed, and this PR has no Terraform-related changes. I’ll fix the workflow separately. This PR is OK to merge.

@diamondpowell
Diamond (diamondpowell) merged commit d6426a2 into main Oct 5, 2026
4 of 5 checks passed
@diamondpowell
Diamond (diamondpowell) deleted the dipowell/crud-workload-timing branch October 5, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants