Repository navigation
Conversation
use cross platform method to set compile definitions moved BaseArithmeticOperatorNode::PerformOperation specializations out of class, to fix build error moved BaseArithmeticOperatorNode::Execute to cpp file to fix build error "specialization after instantiation" redefinition of RecordID in VisualNodeSystem fixed by renaming variable
|
This pull request will have to be merged before I can make the next pull request with the changes to the tests branch. The other pull request takes place on the test branch and requires this change to the master branch. Not sure if it's possible to make changes in separate branches in the same pull request. |
deletion of node causes Segfault in NodeArea::Delete when disconnecting sockets because SocketEvent may cause Sockets to be deleted by user code. Instead notify DESTRUCTION / DISCONNECTED after iterating erase operations to ensure Connection object is not invalidated during iteration.
zoom was not reset leading to positioning being wrong when loading new file
|
Hi @biglari, thank you for this pull request, and sorry for the very late reply. I wanted to set aside enough time to add proper multi-platform support rather than fixing one platform at a time. Please try the latest master and tests branches and let me know if anything still does not build or work for you. |
I wanted to run the tests branch and had various build errors using gcc 14.2 on Linux Mint 22.3, 64-bit. This is an attempt to fix those build errors to be able to build the tests branch on Linux. Another pull request will provide the changes to the tests branch.
Since the Tests build with
VISUAL_NODE_SYSTEM_BUILD_EXECUTION_FLOW_NODESenabled, the fixes to get this to build in the tests branch come down to getting the execution flow nodes to build correctly.The following fixes were made:
BaseArithmeticOperatorNode::PerformOperationspecializations out of class, to fix build errorBaseArithmeticOperatorNode::Executeto cpp file to fix build error "specialization after instantiation"RecordIDinVisualNodeSystem::UnlinkNodeAreasfixed by renaming variableI updated the MasterBranchCode submodule in the tests branch to newest (673cdaa) and then applied the fixes included in this pull request. I then applied fixes to the tests branch until I got it to build. I ran the tests which completed with following results:
Since I was not able to run the tests before applying fixes, I am not sure if the failures were caused by my changes to the master branch, the tests branch, or the updating of the submodule to newest.
I am unable to test on MSVC since I do not have a windows system to test on.