Repository navigation
FIX #1134: accept header-only SPEC files - #1187
Merged
Merged
Conversation
prjemian
commented
Aug 12, 2026
prjemian
commented
Contributor
- Closes APStools version 1.7.9 specwriter incompatible with prior versions #1134
Record that code changes should use a feature branch unless the user says to skip it, and require CHANGES.rst entries to stay concise one-line summaries within the repo line-length limit. Generated by OpenCode (argo/gpt54)
Allow SpecWriterCallback2 to reopen valid SPEC files that only have a file header and no scans yet, matching older apstools output and letting the next scan append cleanly. Add regression coverage for reopening and appending to a header-only file, and record the user-visible fix in CHANGES.rst. Generated by OpenCode (argo/gpt54)
Keep the NXWriter filename test focused on the missing NoneType input rather than interpreter-specific TypeError wording, which changed in Python 3.14. Generated by OpenCode (argo/gpt54)
Reload the temp databroker catalogs for each test so mutable in-memory state cannot leak across the session and randomly change the expected run counts. Generated by OpenCode (argo/gpt54)
Keep the ListRuns fixture check exact by asserting against the apstools snapshot file content instead of the temp catalog length, which varies under the Python 3.14 dependency stack. Generated by OpenCode (argo/gpt54)
Keep the ListRuns query-count checks exact by computing expectations from the apstools snapshot data rather than hard-coding counts that depend on temp catalog query backend behavior under Python 3.14. Generated by OpenCode (argo/gpt54)
Check ListRuns query counts against the catalog search result set used by parse_runs() instead of snapshot-derived counts, while keeping the separate exact snapshot-count assertion. This addresses the Python 3.14 test failure without assuming the backend query stack preserves the same metadata filtering behavior as other environments. Generated by OpenCode (argo/gpt54)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.