Repository navigation
FIX #1166: JPEG writer test sets 8-bit data type - #1192
Merged
Merged
Conversation
The JPEG file writer (NDFileJPEG) only supports 8-bit (UInt8) images. The ADSIM camera default is Float64, which the JPEG plugin cannot encode, so the file open failed and NumCaptured_RBV stayed 0 while the HDF5 and TIFF cases passed. Parametrize the camera data_type (UInt8 for JPEG) and a per-writer file extension for test_bp_count_custom_name, and add pytest.param(id=...) labels. Verified all three plugin cases pass against a live ADSIM IOC. Generated by OpenCode (argo/claudeopus48)
CI failed for the HDF writer (py3.11, py3.14) with NumCaptured_RBV == 0 because a freshly-created plugin was never primed: the frame flowed through (array_counter incremented) but the writer did not capture to file. Prime the plugin (after setting the camera data type) so it captures regardless of prior IOC state. Generated by OpenCode (argo/claudeopus48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_bp_count_custom_name[jpeg1-...]failed withNumCaptured_RBV == 0because the JPEG file writer (NDFileJPEG) onlysupports 8-bit (UInt8) images, while the ADSIM camera default is Float64.
The JPEG plugin could not encode Float64, so the file open failed and no
frame was captured. HDF5 and TIFF accept Float64, so only JPEG failed.
Parametrize the camera
data_type(UInt8 for JPEG, Float64 otherwise)and a per-writer file extension, and add
pytest.param(id=...)labels.Verified all three plugin cases pass against a live ADSIM IOC (three
consecutive runs; full test file: 37 passed).
Analysis recorded on the issue.