Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates model-selection from BEAST2 (2.7.x) / Ant to BEAST3 (2.8.0-beta7) / Maven across 17 commits. Tracked in #14 ("Migrate to beast3").
Build system: Ant → Maven
Parameter → Tensor
BEAST3 replaced beast.base.inference.parameter.Parameter/RealParameter with a generic Tensor type system (beast.base.spec.type.Tensor, RealScalarParam, RealVectorParam, etc.). Updated throughout:
Commons Math → Commons Statistics
BEAST3 dropped org.apache.commons.math (BetaDistribution/BetaDistributionImpl, GammaDistribution/GammaDistributionImpl, ExponentialDistribution/ExponentialDistributionImpl,athException). Replaced withorg.apache.commons.statistics.distribution in GSSTreeDistribution, PathSampler, PathSampleAnalyser, GeneralisedSteppingStone, and the KDE distribution classes. Mostly mechanical: newnstructors became static XDistribution.of(...)factory calls (e.g. BetaDistribution.of(alpha, 1.0)), and the checked MathException is gone, so the surrounding try/catch was
removed. Declared the new module dependency in modul
Evaluator removed
BEAST3 deleted beast.base.inference.Evaluator and si() to a zero-arg method. In PathSamplingStep,PairedPathSamplingStep, and GeneralisedSteppingStoneStep, the old Evaluator-based block is commented out (not deleted) with a TODO explaining why: it was only ever exercised by BEAST2esn't exist in BEAST3 and wasn't used by this package anyway — replaced with a plain operator.proposal() call.
JUnit 4 → 5
Maven release beta1 is https://central.sonatype.com/artifact/io.github.beast2-dev/model-selection
TODO:
Could not find class beast.base.core.BEASTInterface as service when loading BEAUti template #15