Repository navigation
Conversation
Contributor
|
Draft C# pull request: BHoM/CSharpSchema_Test#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
This pull request introduces significant improvements to the CI workflows for linked C# pull requests and PR checks, focusing on modularity, security, and clarity. The main changes include splitting the linked C# PR workflow into three distinct workflows (linked, close, and sweep), introducing two new reusable composite actions (
bhom-assembliesandlinked-pr-context), and enhancing test coverage to reflect these structural updates. Permissions and token usage are now more granular and secure, and the alignment check is now a dedicated job with clearer reporting.Workflow restructuring and modularization:
linked-csharp-pr.yml(for open PRs),linked-csharp-pr-close.yml(for closed PRs), andlinked-csharp-pr-sweep.yml(for scheduled sweeps). This ensures that only relevant jobs appear on the pull request page and that triggers are precise and non-overlapping.alignment) inpr-checks.yml, with a descriptive name and clear failure summaries. The main checks job no longer runs the alignment step directly.Reusable composite actions:
.github/actions/bhom-assemblies/action.yml, a composite action to cache, restore, build, and save BHoM assemblies efficiently, preventing unnecessary rebuilds and ensuring cache freshness..github/actions/linked-pr-context/action.yml, a composite action to gather context about the Python PR, determine eligibility, and enumerate affected C# repositories, ensuring correct gating and secure handling of secrets for fork PRs.Security and permissions improvements:
read) permissions and raise them per job only as needed. The linked job and sweep job getstatuses: writepermission, while the close job does not. Tokens are created only for the repositories touched by the change, and only for steps that require them. [1] [2]Test updates and coverage:
Other improvements:
References: [1] [2] [3] [4] [5] [6]
Test files
Changelog
Additional comments