Repository navigation
Apply small fixes - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
This pull request introduces several improvements to the Python schema generation process, focusing on better handling of missing or redundant assembly folders, improved command-line options, and enhanced test coverage. The most important changes are as follows:
Assembly Folder Cleanup and Reporting:
--clean-missing-assembliescommand-line flag and supporting logic to detect and optionally delete assembly folders that were not generated in a full run, preventing old files from persisting unnoticed. If the flag is not set, a warning is issued instead. [1] [2] [3] [4] [5] [6] [7]File Output Safety:
Test Enhancements:
--clean-missing-assembliesflag is parsed correctly and behaves as expected, and to verify that generated file headers do not include a year range, preventing unnecessary diffs when the year changes. [1] [2]Generated Code Improvements:
Fixture and Type Handling:
DateTimeOffsetproperties are handled correctly in generated code and verified via unit tests. [1] [2]Test files
Changelog
Additional comments