Repository navigation
fix(ci): name the Test_Toolkit commit, and key the dataset-test cache on it - #36
Merged
Merged
Conversation
… on it The compliance rules come from whatever Test_Toolkit's develop holds when the runner cache is cold. That stays, by decision rather than by default, but it is only safe while the version is visible, so the compliance job summary now names the Test_Toolkit commit next to the coverage line. The resolver already recorded it, in a dependency table further up the job, which is not where someone looking at a red is looking. ci-dataset-tests cached its runner under a fixed key, so a Test_Toolkit change did not invalidate it even though DatasetTestRunner copies five Test_Toolkit assemblies into the cached output. It now reads the SHA and folds it into the cache prefix, the way ci-compliance has since it was written. Closes #34 Closes #35
sakanni
marked this pull request as ready for review
October 18, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #34
Closes #35
The compliance rules come from whatever Test_Toolkit's
developholds when the runner cache is cold. That stays, by decision now rather than by default, so the compliance job summary names the Test_Toolkit commit next to the coverage line. The resolver already recorded it, in a dependency table further up the job, which is not where someone looking at a red is looking. When no commit was recorded the line says so, because that also means the cache key lost its Test_Toolkit component on that run.ci-dataset-testscached its runner under a fixed key, so a Test_Toolkit change did not invalidate it even thoughDatasetTestRunnercopies five Test_Toolkit assemblies into the cached output. It now reads the SHA and folds it into the cache prefix, the wayci-compliancehas since it was written.Test files
Three Pester assertions on the compliance summary and five on the dataset-tests cache key, including that both actions read the SHA the same way. Existing tests are unmodified.
Reverting the two action changes fails seven of the eight. The eighth asserts the SHA has one source and passes either way by design, so it covers a later second lookup rather than this change.
Changelog
A compliance run now says which Test_Toolkit commit produced its verdict, and a change to the test engine no longer leaves
ci-dataset-testsrunning an older one out of cache.