Repository navigation
Record why a template job may run twice, and why fixtures stay in scope - #41
Merged
Merged
Conversation
…nd why fixtures stay in scope Where the same job is supplied from two places the definitions have to stay identical, or the two check runs of that name can disagree. Also records why unit-test fixtures are not excluded from dataset compliance: they report Confidence as a warning rather than an error, so the finding stays visible without gating, and excluding them would hide a fixture the engine cannot read. No behaviour change.
sakanni
marked this pull request as ready for review
October 26, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Comment only, no issue.
Test files
None. Comments only, no behaviour change:
actionlintand the workflow lint job cover the file.Changelog
Additional comments
Two comments on the BHE beta template.
The first records that some of these jobs may also reach a repository from an organisation-level required workflow, in which case the same job runs from two places and the two definitions have to stay identical. If they drift, the repository gets two check runs with the same name and different verdicts.
The second records why dataset compliance does not exclude
.ci/Datasets. Since #40 those fixtures reportConfidenceas a warning, so they stay visible without gating, and excluding them would also hide a fixture the engine cannot read.