Repository navigation
Separate each template's concurrency group, and correct what they say about the name - #43
Merged
Merged
Conversation
They said the name CI is what keeps the check contexts bare. A check context is the job name and does not depend on the workflow name. What the name does control is the concurrency group, which is scoped to the repository, so a template sharing a name with a required workflow would let the two runs cancel each other. The comment now says that instead.
The group was built from the workflow name alone, and every template is called CI. A group is scoped to the repository, so any other workflow sharing that name shared the group, and with cancel-in-progress set either run could cancel the other. The prefix names the file, so a template cannot collide with another workflow that happens to be called CI, and two templates in one repository cannot collide with each other. The two required-workflow sources at templates/ root take the same prefix as the required workflows they are copied into; the tier bundles, which stay repository-local, take their own. Nothing else changes: workflow names, triggers, jobs and job names are untouched, so no check context moves.
sakanni
marked this pull request as ready for review
October 27, 2026 00:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #42
Every template was called
CIand built its concurrency group from${{ github.workflow }}. A group is scoped to the repository rather than to one workflow, so any other workflow in that repository calledCIlanded in the same group, and both sides setcancel-in-progress: true. A run that is cancelled never reports a conclusion, so a check someone is waiting on can simply never arrive.The group now carries a literal prefix naming the file, so it does not depend on a workflow name at all, and two templates in one repository cannot collide with each other either. The two required-workflow sources at
templates/root take the same prefix as the required workflows they are copied into; the tier bundles, which stay repository-local, take their own.The comment above
name:said the nameCIis what keeps the check contexts bare. That is not true: a check context is the job name and does not depend on the workflow name. It now says what the name actually controls.Workflow names, triggers, jobs and job names are untouched, so no check context changes.
Test files
None. Each of the eight differs from
developin its comments and itsgroup:line, and in nothing else.Changelog
Additional comments
Nothing is renamed. The prefix makes the workflow name irrelevant to the group, so a rename would buy nothing and would move a name that may already be in use somewhere.