[Tom-Kingstone]

NOTE: Depends on

Issues addressed by this PR

Closes #349
Closes #364

This updates the pollination version to 1.70.19, and fixes problems that arise from this.

Also fixes an issue with plotting evaporative cooling potential from an EPW object.

Test files

Test with the milestone test procedure, and run run_tests.bat.

The batch tests currently throw 3 warnings: a CUDA warning about missing PATH environment variable(won't fix), a deprecation warning about python_toolkit's bson_unix_ticks using deprecated datetime.utcnow() method (to raise issue in python_toolkit and fix there), and a user warning about mismatched handles/labels (won't fix)

Changelog

• Upgraded supported Pollination version to 1.70.19

Additional comments

[bhombot-ci]

Please be advised that the check with reference 126369183420 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 56 additional annotations waiting, made up of 56 errors and 0 warnings.

[SimosManiatis]

Tested it locally, all 240 tests pass.
3 warnings : CUDA, utcnow, legend handles/labels

Small thing: the GH test component (C#) still checks for "=== 237 passed in", so it returns false even when everything passes. Changing that line to this fixed it for me:

List<string> passingLines = lines.Where(line => line.Contains("===") && line.Contains(" passed") && !line.Contains("failed") && !line.Contains("error")).ToList();

Also saw the core check is failing, not sure if that's expected?

[bhombot-ci]

Please be advised that the check with reference 127018530292 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 56 additional annotations waiting, made up of 56 errors and 0 warnings.