Repository navigation
ci(sdk): align protected SDK smoke modes with upstream - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
The private SDK sync run #40939182468 failed closed because the protected public workflow did not match the reviewed template in
Brutich/Bimo(private PR #576).Changes
UsePublishedPackage=falsefor source SDK smoke checks.UsePublishedPackage=truefor published NuGet smoke checks and remove the obsolete 1.1.0 step label..github/workflows/ci.ymlentry ofSOURCE.jsonto match its actual SHA-256. No other file content or hash is changed.Security
This must be merged as a separately reviewed public PR, not through the GitHub App SDK sync token. Do not weaken the synchronization guard or grant workflow-write permissions to the automation. No NuGet publishing or elevated permissions.
Next
After successful public CI and review, merge this public PR. Then rerun the private
Open public Bimo.Tools SDK sync PRworkflow ondevelopandhome. That run can then stage the new Hello BIMO 1.3.0 source + tests and freshly generated completeSOURCE.jsonin its own draft PR.