Skip to content

feat(modeling): add roof-to-floor conversion script - #7

Merged
Brutich merged 1 commit into
mainfrom
codex/roof-to-floor-conversion
Sep 18, 2026
Merged

Brutich merged 1 commit into
mainfrom
codex/roof-to-floor-conversion

Conversation

@Brutich

@Brutich Brutich commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Closes #6.

What changed

  • add a reusable BIMO IronPython script that converts explicitly selected shape-edited Basic FootPrintRoof elements into native Floors;
  • preserve compound structure, base level/elevation, slab-shape vertices, non-boundary creases, sketch holes and supported hosted vertical openings;
  • derive a separate FloorType for each selected RoofType without modifying existing FloorTypes;
  • retain source roofs and dependent annotations; the script never deletes source elements;
  • add rollback-only dry-run mode and all-or-nothing batch rollback on errors or failed geometry validation;
  • validate converted geometry using bidirectional surface samples, volume and total surface-area checks;
  • register the script in catalog.json and the README;
  • add paired user documentation and decision record with the measured Revit 2024 prototype evidence and current limitations.

Inputs

  • IN[0] — dry_run, defaults to true;
  • IN[1] — optional comma-separated roof element IDs; when omitted, the current selection is used.

Validation boundary

The original BIMO MCP prototype was successfully exercised in Revit 2024 on 16 roofs and recreated 6 hosted openings. The generalized repository script has not yet been executed as-is in Revit, so revit.tested intentionally remains empty.

Repository validation is handled by the pull-request workflow:

python tools/validate_catalog.py

Manual Revit smoke testing remains required before claiming the catalog version as tested.

Scope exclusions

  • deleting source roofs;
  • rehosting spot slopes or other dependent annotations;
  • extruded/curtain roofs;
  • curved sketch/opening boundaries;
  • variable-thickness roofs;
  • shaft openings and hosted-family conversion;
  • new Revit-version adapters;
  • BIMO runtime changes.

@Brutich
Brutich marked this pull request as ready for review September 18, 2026 11:02
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@Brutich
Brutich merged commit 93ecc62 into main Sep 18, 2026
1 check passed
@Brutich
Brutich deleted the codex/roof-to-floor-conversion branch September 18, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reusable roof-to-floor conversion script

1 participant