Repository navigation
chore: lint TWD tests with twd-lint - #8
Merged
Merged
Conversation
Adds twd-lint's recommended config to ESLint, scoped to *.twd.test.* files, so missing awaits, wrong runner imports, rule.request.body and .only are reported in the editor and in CI. The existing tests already pass it.
✅ TWD: 7 passed
1 contract warning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds twd-lint to ESLint, so mistakes in TWD tests are reported in the editor and by
npm run lintinstead of in a failing browser run:recommendedapplies to*.twd.test.*files only, so app code and other rules are untouched. It reports missingawaits on async TWD calls,describe/it/expectimported from the wrong module,rule.request.bodyon awaitForRequestresult, and.onlyleft behind.The existing TWD tests already pass it: no new reports.
Checked
npx eslint .reports the same as before on everything that is not a TWD test (0 errors and 4 warnings onmain, unchanged).it.onlyand an un-awaitedtwd.visitis reported by this repo's ESLint, so the plugin is active.🤖 Generated with Claude Code