fix(home): show last stop instead of live cues after trip ends - #8
Merged
Merged
Conversation
GET /api/home still returns the most recent stop when nothing matches today, so the card kept "Currently At", the pulse dot, and an "On the Road" postmark after Vilnius had ended. Add current_stop_is_live and drive CurrentLocationCard from it, with stopLive.js as a fallback when older APIs omit the field so web-before-API deploys do not mark every trip ended. Open-ended stops now stay live through departure day, stale is_current on past stops is ignored, and trip/stop badges share the same rules. Postmark dates use the calendar portion of stop dates to avoid timezone drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current_stop_is_livetoGET /api/homeso the frontend can distinguish a live stop from the fallback last stopstopLive.jsacross home and trip pages so staleis_currentflags no longer show "currently here" on ended stopsTest plan
pytest api/tests/test_home_current_stop.py(8 cases)