Repository navigation
Redact an order number given in a sentence, not only after a colon - #36
Merged
aryanorastar merged 1 commit intoOct 11, 2026
Conversation
"Order number: 22777" was removed from a public issue, but "my order number is 22777", "order ID is 31415" and "the ticket number was 138637367" were published as written. The rule now also accepts "is", "was", "=" and "-" before the number, for four digits or more so a price or a count after "order was" is left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer problem
A customer who writes "my order number is 22777" in a report gets the number published in the public GitHub issue.
redactSensitiveremoves "Order number: 22777" and "order 22777", but not the same thing said in a sentence: "order ID is 31415", "the ticket number was 138637367", "order no. is #27182".Change
The order rule also accepts "is", "was", "=" and "-" between the word and the number. That form needs four digits or more, so "my order was 299 dollars" and "the order is 2 weeks late" are left alone.
Evidence
privacy.jssets the rule itself: public GitHub issues must never carry raw customer identifiers. Old and new redaction run over every string literal in the repo's sources, tests and scripts (3174) differ on the new test line and on one log line intest/shopify.test.js, whereorder=1042now becomes[order number].Verification
test/privacy.test.js. The first fails on main; the second keeps prices and counts unchangednpm test: 628/628EVAL_NO_MODEL=1 node scripts/customer-eval.js: 8/8.env, orrailway.toml(the numbers in the tests are made up)Touches different lines from #34 and merges cleanly with it.