Repository navigation
Catch a promise to tell the team when it is written with "I'll" - #39
Merged
aryanorastar merged 1 commit intoOct 11, 2026
Merged
aryanorastar merged 1 commit into
aryanorastar merged 1 commit into
Conversation
The staff-lie filter removed "I will make sure the team sees this" but not "I'll make sure the team sees this": the pattern read "i (will|I'll)", so the contraction never matched. Promises in the future tense were not covered at all, so "I'll let the team know" and "I'll flag this to support" reached the customer though nobody had been told. Both forms are caught now, with a straight or a curly apostrophe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer problem
The bot can tell a customer "I'll make sure the team sees this" or "I'll let the team know" when nobody has been told. The staff-lie filter removes "I will make sure the team sees this", but its pattern reads
i (will|I'll), so the contraction never matches. Promises in the future tense are not covered at all: "I'll flag this to the team", "I'll forward this to support", "I'll escalate this for you".Change
The contraction is fixed, and the same promise is caught in the future tense: "I will", "I'll" or "I'm going to", then let, tell, notify, flag, forward, escalate or pass, aimed at the team, staff, support or a person. A straight or a curly apostrophe both match. "I'll tell you how to contact support" and "let the team know in this thread" are left alone.
Evidence
AGENTS.md: a customer is told honestly what happens next, and the PR checklist forbids any claim that a person was pinged without confirmed success. Old and new verdicts over every string literal in the repo's sources, tests and scripts (3192) differ only on the new test lines.
Verification
test/honesty.test.js. The first fails on main; the second keeps offers the customer can act onnpm test: 628/628EVAL_NO_MODEL=1 node scripts/customer-eval.js: 8/8.env, orrailway.toml