Skip to content

Localize customer closing cards from stored case language - #43

Merged
aryanorastar merged 2 commits into
mainfrom
fix/localized-closing-card
Oct 12, 2026
Merged

aryanorastar merged 2 commits into
mainfrom
fix/localized-closing-card

Conversation

@aryanorastar

Copy link
Copy Markdown
Collaborator

Customer failure prevented

A Spanish support case received an English “How did we do?” closing card. The card now uses the case's persisted context.replyLanguage, the same source used by acceptance notices, rather than the resolving staff member's locale.

Scope

  • Localize the title, four description paragraphs, optional honest-review field and all four button labels for the 14 acceptance-copy languages. Missing/unknown language falls back to the existing English payload; regional tags fall back to the base language and both supported Hindi scripts remain distinct.
  • Preserve rate:yes / rate:no, store URLs, customer-only voting, disabled mentions and customer-send-before-case-close ordering. No provider calls, new private capability or feedback gating.
  • Card content only: staff acknowledgments and subsequent feedback replies are deliberately unchanged.
  • Update architecture, runbook and implementation checklist to distinguish shipped Show live staff case progress and announce real acceptance #41 from this undeployed correction.

Verification

  • Seven new tests: five failed before implementation, all pass afterward. Spanish and Chinese assertions cover every card section/button; integration tests exercise stored case language and unknown fallback.
  • Full npm test: 668/668 pass before push. Offline customer check: 8/8.
  • English payload compared directly with pinned main b9eeb16: identical, including the missing-staff fallback.
  • Supported-language set contract matches ACCEPTANCE_COPY; Discord component validation succeeds and link/ID semantics are unchanged.

Release gate

Draft for review. Do not merge or deploy before #42 passes its fresh comparison and ships. Then release this correction separately, retaining the 24-hour clean interval unless explicitly waived. Synthetic Spanish/Chinese /done release smoke remains pending. No Railway or credential changes.

@aryanorastar
aryanorastar marked this pull request as ready for review October 12, 2026 08:44
@aryanorastar
aryanorastar merged commit dad2505 into main Oct 12, 2026
3 checks passed
@aryanorastar
aryanorastar deleted the fix/localized-closing-card branch October 12, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant