fix(admin): delete organization instances - #88
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
|
All contributors have signed the CLA. Thanks! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Delete an operator-managed organization together with its stored instance connections. Instance rows were only soft-deleted before the organization delete, so SQLite foreign-key enforcement rejected the transaction and retained the organization data.
Why
The
instances.org_idforeign key has no cascade, andinstance_events.instance_idalso requires its rows to be removed first. The deletion helper now removes instance events, instances (including stored admin tokens), invitations, and memberships in one transaction before deleting the organization.Testing
npm test— passed (230 tests)npm run check— passed with 0 errors and 10 pre-existing warningsLAUNCHPAD_JWT_SECRET=test npm run build— passedgit diff --check— passedCloses #61