Skip to content

wallet: public_descriptors ignores the seed it's given #128

Description

@BenWestgate

core_descriptors(secret, ...) calls BitcoinCore.public_descriptors and returns the descriptors of whatever HD key the named Core wallet holds. It only type-checks secret, so a wallet holding a different seed returns that wallet's descriptors.

Nothing needs this path: ms32 wallet gives Core the root xprv (addhdkey) and Core builds the descriptors (createwalletdescriptor). Pre-1.0, remove it rather than authenticate it.

Fix in #130:

Absorbs #63 (same removal) and #64. Found by Codex review of #94, after the four supplied audit reports; not attributable to those reviewers.

Activity

  1. added
    area: apiPublic and supported Python API boundaries.
    area: securitySecurity invariants, hardening, and security-sensitive boundaries.
    area: wallet/coreWallet integration and Bitcoin Core boundaries.
    bugSomething isn't working
    gate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.
    on Oct 5, 2026
  2. added 4 commits that reference this issue on Oct 8, 2026
    69cd2c4
    b15909f
    85e8621
    bce191f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: apiPublic and supported Python API boundaries.area: securitySecurity invariants, hardening, and security-sensitive boundaries.area: wallet/coreWallet integration and Bitcoin Core boundaries.bugSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions