Repository navigation
wallet: public_descriptors ignores the seed it's given #128
Copy link
Copy link
Open
Labels
area: apiPublic and supported Python API boundaries.Public and supported Python API boundaries.area: securitySecurity invariants, hardening, and security-sensitive boundaries.Security invariants, hardening, and security-sensitive boundaries.area: wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.bugSomething isn't workingSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.
Description
Activity
- addedarea: apiPublic and supported Python API boundaries.Public and supported Python API boundaries.area: securitySecurity invariants, hardening, and security-sensitive boundaries.Security invariants, hardening, and security-sensitive boundaries.area: wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.bugSomething isn't workingSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.
on Oct 5, 2026 - added 8 commits that reference this issue
on Oct 5, 2026 - marked api: Stop exposing Bitcoin Core descriptor records #63 as a duplicate of this issue
on Oct 7, 2026 - added 4 commits that reference this issue
on Oct 8, 2026
Metadata
Metadata
Assignees
Labels
area: apiPublic and supported Python API boundaries.Public and supported Python API boundaries.area: securitySecurity invariants, hardening, and security-sensitive boundaries.Security invariants, hardening, and security-sensitive boundaries.area: wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.bugSomething isn't workingSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.
core_descriptors(secret, ...)callsBitcoinCore.public_descriptorsand returns the descriptors of whatever HD key the named Core wallet holds. It only type-checkssecret, so a wallet holding a different seed returns that wallet's descriptors.Nothing needs this path:
ms32 walletgives Core the root xprv (addhdkey) and Core builds the descriptors (createwalletdescriptor). Pre-1.0, remove it rather than authenticate it.Fix in #130:
core_descriptors,WalletPublicDeriverand the unused descriptor-record path (codex32.__all__drops to 22 names);master_xprvand Wallet: use Core for setup and remove test crypto deps #7's Core-native account-0 setup; nonzero accounts stay in wallet: Support nonzero accounts with Core-native setup #68.Absorbs #63 (same removal) and #64. Found by Codex review of #94, after the four supplied audit reports; not attributable to those reviewers.