Skip to content

cli: Define stable correct exit statuses #39

Closed

Description

@BenWestgate

correct needs distinct, stable statuses for valid input, suggestion emitted, no usable suggestion, and usage/input errors. Suggestions remain nonzero as required by the security model.

Implemented and reviewed in PR #45 with this contract:

  • 0: input is already valid;
  • 1: a correction suggestion was emitted;
  • 2: command or input syntax is invalid;
  • 3: no usable suggestion was emitted, including no result, incomplete search with no usable candidate, ambiguity, refused disclosure, or a missing dependency needed to present a suggestion.

#45 is already merged into #42's branch, so the implementation now lives at the current #42 head. Keep this issue open until #42 is integrated into reviewability-v1; GitHub does not auto-close it when #45 merges only into that intermediate branch. The final #42 integration should rerun the existing status/correction regression suite on the combined tip.

Activity

  1. added
    enhancementNew feature or request
    gate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.
    area: cliCommand-line interface behavior.
    area: correctionCorrection engine and correction UX.
    on Sep 24, 2026
  2. added 20 commits that reference this issue on Sep 27, 2026
    eb7cfdd
    300cc7f
    87f0ff8
    4711682
    d4580f5
    19b57a9
    9e40323
    73109ed
    d23e860
    002dbb0
    2a82d70
    205ae38
    bfd8b1b
    794f898
    07ee68c
    4cad92c
    8283e78
    4be79a7
    606bbac
    afdeffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliCommand-line interface behavior.area: correctionCorrection engine and correction UX.enhancementNew feature or requestgate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions