reviewability: restore the <5000 installed-package budget on the integrated v1 tree #61
Closed as not planned
Description
A disposable integration from reviewability-v1 26f933e exposed a release-gate failure that individual PR CI cannot see.
Current logical review-line counts (nonblank, non-comment src/codex32/**/*.py, matching test_production_size_budgets_are_enforced):
- base
26f933e: 4,893 - after wallet: Validate Bitcoin Core state types #12/bip93: Reject non-ASCII normalized input #13/docs: Define trusted-computer boundary #59/Wallet: use Core for setup and remove test crypto deps #7/ci: Verify wallet fixtures against Bitcoin Core #51/bip93: reject HRPs longer than 83 characters #33: 4,927
- after correct: Interpret mixed-case damage #42: 5,033
- after Define correction exit statuses #45: 5,033
- after wallet: Require the recorded fingerprint before import #57: 5,137
- after replaying the single Remove pre-review CLI dead code #46 cleanup commit while preserving wallet: Require the recorded fingerprint before import #57: 5,098
docs/developer/api.md requires the installed v1 package to remain below 5,000 lines and says changing that budget requires explicit review and authorization. Do not raise the threshold as part of this issue.
Acceptance:
- reduce the integrated production tree to
<5000without weakening correct: Interpret mixed-case damage #42 mixed-case correction or wallet: Require the recorded fingerprint before import #57 verify-before-mutate / wallet-record behavior; - keep the cleanup focused on real review-surface reduction, not formatting compression or moving live runtime code outside the counted package;
- rerun the exact production-size test on the combined tree plus normal/optimized tests covering touched paths;
- fold the final result into the one-time post-prerequisite cleanup refresh before the frozen adversarial-review candidate is declared.
The disposable integration worktree only produced local synthetic commits; no project branch was changed.
Activity
BenWestgate commentedon Sep 28, 2026
Sizing follow-up: #53 is only +4 logical package lines versus current
reviewability-v1; #23/#52 do not materially add production package code. The present integrated estimate is therefore about 5,102 before #53's planned shared ASCII-helper deduplication.The GUI does not count against this cap: it is a separate
src/codex32_guipackage with its own enforced<2000budget. Current heads measure 1,983 lines for #28 and the preflighted #10+#28 combination is 1,997. So #61 is specifically a roughly 100-line library/CLI review-surface problem.BenWestgate commentedon Sep 28, 2026
Maintainer decision on 2026-09-28 supersedes this issue's earlier “do not raise the threshold” condition: the authorized v1 installed-package cap is now
<5200, specifically to avoid a riskier pre-release refactor whose only purpose would be shaving ~100 already-reviewed lines. PR #62 is the focused policy/enforcement change and is green. Keep this issue open until #62 lands; no production refactor is required to close it.