Skip to content

generation: Validate supplied BIP32 seeds #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWestgate merged 1 commit into from
Sep 28, 2026
Merged

generation: Validate supplied BIP32 seeds #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/codex32/generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
)
from codex32.errors import (
CeremonyStateError,
CodexError,
HeaderCollision,
InvalidIdentifier,
InvalidLength,
Expand Down Expand Up @@ -155,6 +156,8 @@ def generate_master_seed(
"""Generate or encode one unshared ``ms`` secret."""
supplied, length = _seed_input(seed_bytes, byte_length)
if supplied is not None:
if not _valid_root(supplied):
raise CodexError("master seed does not form a valid BIP32 root")
identifier = _random_identifier() if identifier is None else _identifier(identifier)
return MasterSeed.from_seed(supplied, identifier=identifier)
if identifier is None and fingerprint is None:
Expand Down
7 changes: 7 additions & 0 deletions tests/test_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from codex32.bech32 import _u5_to_chars
from codex32.errors import (
CeremonyStateError,
CodexError,
HeaderCollision,
InvalidIdentifier,
InvalidLength,
Expand Down Expand Up @@ -139,6 +140,12 @@ def test_raw_bytes_accept_random_or_explicit_identifiers() -> None:
assert secret.header.identifier == "test"


def test_supplied_seed_must_form_a_valid_bip32_root(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setattr(generation_module, "_valid_root", lambda _seed: False)
with pytest.raises(CodexError, match="master seed does not form a valid BIP32 root"):
generate_master_seed(bytes(16), identifier="test")


def test_explicit_and_random_output_order_contracts() -> None:
source = generate_master_seed(bytes(range(16)), identifier="test")
_secret, shares = _complete(
Expand Down
Loading