Repository navigation
Test optimized mode and constants in CI - #47
Merged
Merged
Conversation
Run the full suite under Python optimization and re-derive the frozen correction constants in one Ubuntu/Python 3.13 matrix leg. Avoid multiplying the expensive optimized run across every platform.\n\nSecurity: CI now detects behavior that depends on runtime assertions and drift in frozen BCH parameters.\n\nValidated the constant verifier locally and parsed the workflow YAML.\n\nFixes #40
BenWestgate
added
area: ci
BenWestgate
commented
Sep 25, 2026
BenWestgate
left a comment
BenWestgate
left a comment
Owner
Author
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
ACK 0aff580
- Both new steps ran green on the ubuntu/3.13 leg.
- Nit: the repeated
if:could be a matrixincludeflag, but two lines is fine.
Owner
Author
|
Release-gate sequencing: merge #50 before final review/merge of this PR. Both change |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40.
Add two assurance steps to the existing Ubuntu/Python 3.13 matrix leg:
python -O;Restricting these checks to one representative matrix leg avoids multiplying a full optimized test run across every OS and Python version. No dormant fuzz harness is enabled.
Local validation:
python tools/verify_correction_constants.pygit diff --check