Repository navigation
correct: Type the correction deadline as always set - #82
Closed
BenWestgate wants to merge 1 commit into
Closed
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
_correction_candidates always fills in a missing deadline before returning it, but its annotation still said float | None. The mixed-case scheduling commit feeds that value back into the local deadline, so mypy rejects both assignments and CI fails on every OS. Narrow the return annotation to float. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E75K4nCzge7jFwjwDgeBrR
Owner
Author
|
Superseded by #42 head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Before: #42's head (
7e398b0, "Schedule embedded mixed-case recovery") fails CI on all six OS/Python jobs. Tests pass, but mypy reports two errors atsrc/codex32/_cli_input.py:549and:565, where it assignsfloat | Noneto a variable typedfloat.After: mypy is clean and #42 can go green once this is merged into its branch.
_correction_candidatesalways fills in a missing deadline (deadline = monotonic() + 10 if deadline is None else deadline) before it returns one. Its return annotation still saidfloat | None, and the new scheduling code feeds that value back into the localdeadline.How: the return annotation now says
float. There is no runtime change.Checked on Python 3.13 with mypy (clean), ruff check and format (clean), and 887 tests passing in both normal and
-Omode.🤖 Generated with Claude Code
https://claude.ai/code/session_01E75K4nCzge7jFwjwDgeBrR
Generated by Claude Code