Repository navigation
feat: Beckman Vi-Cell BLU - support per-sample detail export - #1277
Open
nathan-stender wants to merge 1 commit into
Open
nathan-stender wants to merge 1 commit into
nathan-stender wants to merge 1 commit into
Conversation
The detail export has a sample settings section, a reagent table, and a per-image results table ending in a "Total" row. Flatten each sample into the summary-export row shape, and update sniff to find the results header on the "Image#" line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ajcariaga16
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vi-Cell BLU's per-sample detail export currently fails with
Expected non-null value for Viability (%). The parser only handles the flat summary export (one row per sample), but the detail export has:Totalrow that holds the sample-level resultspandas read every row against the settings header, so the results columns came out empty. Sniff also missed the file, because
Viability (%)isn't on its first line.Changes
Sample IDand there is anImage#table) and turns each sample into one summary-style row: settings, then reagent info, then theTotalrow's results. Files with several samples are supported. Summary exports take the same path as before.Image#line when it exists, and on the first line otherwise.Beckman_Vi-Cell-BLU_detail_export.csv, an anonymized customer file cut to 3 image rows.Notes
ROW/COLUMN/Concentration Adjustment Factor (%)go into custom information. If a sample lists more than one reagent, the reagent info is left out.SeriesData._get_custom_key). This is existing behavior across all parsers and is not changed here.Testing
tests/discover_vendor_test.pypass (342 tests), and lint passes.🤖 Generated with Claude Code