Repository navigation
docs: make the example scores run when copied into a fresh repository - #509
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concern: the example scores run when copied into a fresh repository.
A smoke test of v0.2.0 copied
examples/solointo a fresh one-packagepackage mainGo module, changed only the instruction, and hit four points of friction. This PR fixes each one in the examples themselves.Friction fixed
go build ./...failed the attempt. When./...matches a singlemainpackage,go buildwrites a binary named after the module into the tree, so the attempt failed withacceptance_mutated_workspacealthough the command exited 0. Everybuildcriterion insolo/,solo-gated/, andgated/is now["go", "build", "-o", "/dev/null", "./..."], and the README states the rule behind it as rule 6: an acceptance criterion must not write into the workspace. No example instruction tells the writer to rungo build, so no instruction wording changed.runrefused a dirty repository. The README said only "copy, edit, run". A new "Before the first run" section gives the exact steps:partitur init(which writes.partitur/.gitignoreand never overwrites an existingpartitur.yaml, so the example's score is kept), copy the two files, then commitpartitur.yaml,.partitur/.gitignore, and.partitur/cast.yamlbefore the firstrun. The cast is listed too: it lives under.partitur/but is not ignored, so an uncommitted cast also makes the repository dirty.status. The README now saysname:and every movementid:are free to rename (and thatneeds:/final_movementmust follow a renamedid, and part names must match the cast).claudeperformers (so the binding keeps a fallback) and explains why each keepsallow_advisory_enforcement: true: theclaudeadapter reportsnetwork_grants: false.Verification
go test -count=1 ./examples/...passes (every example still compiles as a score and binds as a cast).gofmt -l examplesis empty;go build ./...andgo vet ./...pass.go build -o /dev/null ./...also passes on this multi-package repository, so the examples' criteria still work where their instructions point.package mainmodule, the README's "Before the first run" steps followed verbatim with the fixedexamples/soloscore (instruction changed to add aGreetfunction,name:and movementid:renamed), and the Claude-only cast from the new note.validateexited 0 with the expectedunmet=["network_grants"]advisories;runreached SUCCEEDED on the first attempt with all three criteria verified;statusreported the renamed movement;applylanded the change inmain.goandmain_test.gowith no stray build output in the tree.The whole-repository test battery was not run: this change touches only
examples/(three YAML criteria and the README), andexamples_test.gois the test that covers them.🤖 Generated with Claude Code