Skip to content

What's changed: WHATS-CHANGED.md back to 2018 and a page on the site - #131

Merged
noneck merged 4 commits into
v2from
feature/whats-changed
Nov 13, 2026
Merged

noneck merged 4 commits into
v2from
feature/whats-changed

Conversation

@noneck

@noneck noneck commented Nov 13, 2026

Copy link
Copy Markdown
Member

Part of BetaNYC/betanyc-ai-workspace#1646 (epic BetaNYC/betanyc-ai-workspace#1637).

What changed

Tests (office, 2026-11-12)

Playwright 94 passed, 17 skipped (46/14 before). Unit 171 passed. svelte-check 0 errors. Build OK.

Shared parts

  • whats_changed.py is copied unchanged from BetaNYC's shared What's changed code (version 1.2.3); a drift check confirms the copy is current.
  • The page has one heading, landmarks, a skip link, dates in <time>, and a keyboard filter that shows only the tags this site uses. With JavaScript off, every entry shows. Checked at 320px wide.
  • CI runs whats_changed.py check --base-ref (format, link safety, append-only) and checks the page matches the file.

QA

Adversarial code review and qa-credibility, two rounds each, both SHIP. Every entry was checked against git history, merged PRs and issues.

🤖 Generated with Claude Code

noneck and others added 4 commits November 12, 2026 20:38
…CI check

Adopts the BetaNYC What's changed standard (betanyc-ai-workspace#1646, epic #1637).

- WHATS-CHANGED.md: 24 entries from the record (v1 change log in main's README,
  commits, gh-pages deploys, issues and PRs; v2 PRs dated by when their deploy finished,
  New York time). History begins 2018-07-11. One correction (2020-08-10: licenses drawn
  in the wrong place for about 12 minutes; dates missing for about half an hour).
- scripts/whats_changed.py v1.2.1, copied unchanged from the workspace.
- site: /whats-changed/ route renders the generated fragment with {@html} under its own
  h1; prerender = true, csr = false. The built page carries exactly one <script>, the
  fragment's filter script, and it runs (Playwright). The address search needs the
  SvelteKit client, so the layout leaves it out on this page instead of showing a dead
  control. Footer link on every page, with data-sveltekit-reload.
- `npm run whats-changed` (also prebuild) writes site/src/lib/whats-changed.html.
- e2e: the page joins pages.js (axe and phone width at all three sizes); new
  whats-changed.spec.js (h1, landmarks, <time>, no-client script, keyboard filter and
  live region, JS off, 44px targets, 320px, footer link on every page, Back).
- CI (v2-site-a11y.yml): full-history checkout, `check --base-ref`, `render --check`.
- README: points to the file and the page.

Merges cleanly with open drafts #123 and #128 (git merge-tree).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iven tests

- scripts/whats_changed.py v1.2.3 copied unchanged; fragment re-rendered (filter now
  shows only Site, Data and Corrections only).
- New correction 2026-11-05: 500-foot counts on 499 address pages were off, mostly by
  1 to 3 (PR #98); removed from the LAMP feature entry.
- 2020-08-10 correction advice reworded (4:12 to 4:44 pm, from commit timestamps).
- e2e/whats-changed.spec.js: counts from `whats_changed.py json`; a dated <time> per
  dated entry, not one per entry; checkbox count from the tags in use; filter checks
  skip when the module omits the filter; the csr check always runs; skip link in the
  44px check.
- app.css: skip link at least 44px tall.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On GitHub's Linux runner the What's changed page measured 325px wide at 320px. The
overflow was the site header's nav ("Districts About Glossary Rules"), not the page
fragment: it is a non-wrapping flex row, and wider Linux fonts push "Rules" past the
edge. The nav now wraps (flex-wrap, min-width: 0). Every page shares the header.

The 320px test now also measures with a wide font (Verdana / DejaVu Sans), so it fails on
macOS without this fix (323 > 320) and passes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@noneck
noneck merged commit ae5ec3d into v2 Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant