Improve Android camera failure diagnostics - #31
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android camera failures previously recorded only a generic Media3 error code, making failures such as
ERROR_CODE_IO_UNSPECIFIEDdifficult to diagnose.Include camera ID, stream selection, retry state, bounded nested exception types and stack locations, known network categories, and recognized RTSP method/status codes. Record startup failures, stalled or ended streams, reconnect timing, and recovery. Exclude arbitrary exception messages and stream URLs to protect credentials.
Validation: four Kotlin/JUnit diagnostic tests passed, covering credential exclusion, RTSP status filtering, cyclic/deep cause chains, and identifier validation.
git diff --checkpassed. Full Android build and device validation remain pending because the local environment has no Android SDK.