Skip to content

Restrict Linux OS updates to full BetterFrame OS installations - #36

Merged
mrinc merged 2 commits into
masterfrom
fix/linux-app-update-reboot
Sep 24, 2026
Merged

mrinc merged 2 commits into
masterfrom
fix/linux-app-update-reboot

Conversation

@bcbetterninja

Copy link
Copy Markdown
Contributor

Linux app-only installations could enter OS OTA when BF_ENABLE_OS_OTA=0 was missing. Require the full BetterFrame image's OS version, compatibility identity, and RAUC configuration before checking or applying OS updates, including forced updates. Recheck eligibility after download and report the same eligibility in heartbeats. App updates continue to restart only the app.

Clear inherited systemd SuccessAction alongside failure/start-limit actions when repairing standalone installations. Existing service configuration requires rerunning the updated installer. The reported device's exact reboot cause has not been confirmed from device logs.

Validation:

  • 18 Rust tests passed in a harness compiling the actual app/OS update modules, including public/authenticated/forced rejection on an app-only host and all image-marker combinations.
  • 33 installer tests passed; 2 skipped.
  • 13 OS lifecycle tests passed.
  • Shell syntax and diff checks passed.
  • Full GUI build not run locally: GTK/GStreamer/WebKit development packages are unavailable.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e9fc18e7-ac50-4959-aabe-8916f3fbcdf5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a3ee6c296

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread client/src/platform/linux/ui.rs
@mrinc
mrinc merged commit 6f08a19 into master Sep 24, 2026
10 checks passed
@mrinc
mrinc deleted the fix/linux-app-update-reboot branch September 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants