Skip to content

Fix move row race blocking the release - #21

Merged
mrinc merged 2 commits into
masterfrom
fix/release-move-list-race
Sep 13, 2026
Merged

mrinc merged 2 commits into
masterfrom
fix/release-move-list-race

Conversation

@bcbetterninja

Copy link
Copy Markdown
Collaborator

The v0.2.59 Linux release tests failed twice because a queued delete could leave its row in the inbox. Full-body hydration can observe the optimistic destination during the feedback interval; the removal code treated that updated message metadata as evidence that the user had navigated to the destination.

Use the selected folder to decide whether the destination is being viewed, and remove source-list rows even when hydration has already updated their folder. The regression test explicitly injects that interleaving and awaits the local action before checking the list while the remote move remains blocked.

Validation: Release build and complete regression suite. The v0.2.59 release remains unpublished; this fix must land before a new release tag is created.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8ebfab66-3326-49c3-b5e3-0a04f11159a6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88ed0ebb1e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/BetterMail.App/MainWindowViewModel.cs Outdated
@mrinc
mrinc merged commit dd86a8b into master Sep 13, 2026
9 checks passed
@mrinc
mrinc deleted the fix/release-move-list-race branch September 13, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants