Fix move row race blocking the release - #21
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88ed0ebb1e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The v0.2.59 Linux release tests failed twice because a queued delete could leave its row in the inbox. Full-body hydration can observe the optimistic destination during the feedback interval; the removal code treated that updated message metadata as evidence that the user had navigated to the destination.
Use the selected folder to decide whether the destination is being viewed, and remove source-list rows even when hydration has already updated their folder. The regression test explicitly injects that interleaving and awaits the local action before checking the list while the remote move remains blocked.
Validation: Release build and complete regression suite. The v0.2.59 release remains unpublished; this fix must land before a new release tag is created.