Correct sync colour transitions and simplify Busy navigation - #25
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60dd1e4cee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0526ba84e1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
The sync icon previously derived red from lifetime action failure counts and repeated workspace errors, so ordinary syncing could look stuck. Track completed sync outcomes instead, and present Busy as a normal folder row with a right-aligned count.
Validation: Release build with zero warnings/errors; 527 tests pass. State-transition coverage includes high historical counts, orange retry, red persistence, completed empty-queue reset, and workspace warnings. Native Xvfb checks assert actual orange/red brushes on both controls in light/dark mode. Screenshots contain fictional data only.
On the first persisted Busy load, failed actions seed orange and failed-ID history; paused actions and unconfirmed sends seed red. Restart cannot present these as ordinary pending work. Initialization runs once so later refreshes cannot resurrect resolved attention state. Regression tests cover each startup case, next-run escalation and reset after an empty completed sync.
Busy severity is separate from aggregate sync warnings: mailbox/workspace failures do not colour clean newly queued Busy actions. Regression tests cover failures both before and after clean work is queued, Busy escalation, and independent clearing of the Busy state.