Skip to content

Fix setcchar() for an empty wide string #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bill-Gray merged 1 commit into from
Sep 15, 2026
Merged

Fix setcchar() for an empty wide string #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pdcurses/util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ int setcchar(cchar_t *wcval, const wchar_t *wch, const attr_t attrs,
{
int32_t ochar[CCHARW_MAX], rval;
const int integer_color_pair = (opts ? *(int *)opts : (int)color_pair);
int n;
#ifdef USING_COMBINING_CHARACTER_SCHEME
int i;
#endif
Expand All @@ -337,13 +338,14 @@ int setcchar(cchar_t *wcval, const wchar_t *wch, const attr_t attrs,
assert( wch);
if (!wcval || !wch)
return ERR;
if( _wchar_to_int32_array( ochar, CCHARW_MAX, wch) < 0)
n = _wchar_to_int32_array( ochar, CCHARW_MAX, wch);
if( n < 0)
return ERR;
rval = ochar[0];
/* If len_out > 1, we have combining characters. See */
/* If n > 1, we have combining characters. See */
/* 'addch.c' for a discussion of how we handle those. */
#ifdef USING_COMBINING_CHARACTER_SCHEME
for( i = 1; ochar[i]; i++)
for( i = 1; i < n; i++)
rval = COMBINED_CHAR_START + PDC_find_combined_char_idx( rval, ochar[i]);
#endif
*wcval = rval | attrs | COLOR_PAIR(integer_color_pair);
Expand Down