fix(sdk-core): use decrypt/encrypt in createOfflineKeyGenRound1Share#9248
Merged
Conversation
Contributor
BitGoBase.decrypt and .encrypt already return Promise<string>; the Async variants do not exist and caused a TS2339 build failure on master for every package depending on sdk-core. Ticket: WCI-1023
Marzooqa
force-pushed
the
wci-1023-fix-decryptasync-encryptasync
branch
from
13650ce to
8a49c2d
Compare
Marzooqa
changed the title
pritam-gembali
approved these changes
Jul 14, 2026
biwwy0
approved these changes
Jul 14, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace two non-existent method calls in
createOfflineKeyGenRound1Share(modules/sdk-core/src/bitgo/utils/tss/eddsa/eddsaMPCv2.ts):this.bitgo.decryptAsync(...)→await this.bitgo.decrypt(...)this.bitgo.encryptAsync(...)→await this.bitgo.encrypt(...)Also removes the
isV2Envelopebranch —decrypthandles both envelope versions and already returnsPromise<string>.Why
PR #9187 merged these non-existent methods to master, causing
TS2339build failures in@bitgo/sdk-coreand every downstream package. This unblocks all PRs currently failing CI with:Test plan
@bitgo/sdk-coreTicket: WCI-1023