Skip to content

header with a hamburger feature for small screens - #7

Open
TimOsahenru wants to merge 1 commit into
BlackPythonDevs:mainfrom
TimOsahenru:main
Open

header with a hamburger feature for small screens#7
TimOsahenru wants to merge 1 commit into
BlackPythonDevs:mainfrom
TimOsahenru:main

Conversation

@TimOsahenru

Copy link
Copy Markdown

Implemented header feature for large screens image and small screens
image for this issue #2

@TimOsahenru
TimOsahenru requested a review from kjaymiller July 27, 2026 11:01

@kjaymiller kjaymiller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimOsahenru

IMHO we should stick with the base_templates/_base.html format as it can have benefits.

I would suggest that you make these changes within the base.

I'd also consider making the css its own file or update the bpd.css we can also update the nav attribute.

@TimOsahenru

Copy link
Copy Markdown
Author

Hello @kjaymiller what do you mean by sticking to base_templates/_base.html should I create the directory and file ? also clarify what making changes in the base means, cos all changes were made from the _base.html thank you.

@kjaymiller

Copy link
Copy Markdown
Contributor

Hello @kjaymiller what do you mean by sticking to base_templates/_base.html should I create the directory and file ? also clarify what making changes in the base means, cos all changes were made from the _base.html thank you.

Your template overwrites the render-engine default base which could have some side-effects. I suggest that you keep the original extensions and add your changes in the blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants