Repository navigation
Add agency_id's to service alert informed entities - #204
Merged
Merged
Conversation
Member
|
This is great - thanks for the pull request. This is included in the latest version https://github.com/BlinkTagInc/node-gtfs/releases/tag/4.19.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again!
Currently, the
service_alert_informed_entitiestable does not include anagency_idcolumn, even though this is a valid entity in the spec. This is fine for most cases, but if data from multiple agencies is being consumed, it leads to a situation where a system-wide alerts (eg, where the only informed entity is the agency) cannot be reconciled back to which agency issued them.This PR:
agency_idcolumn toservice_alert_informed_entitiesThanks!