Skip to content

0.8.0 release - #422

Merged
KyrylR merged 2 commits into
masterfrom
release/0.8.0
Sep 26, 2026
Merged

KyrylR merged 2 commits into
masterfrom
release/0.8.0

Conversation

@KyrylR

@KyrylR KyrylR commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Also I have migrated to latest version of the rust-simplicity

@KyrylR KyrylR self-assigned this Sep 23, 2026
@KyrylR
KyrylR requested a review from delta1 as a code owner September 23, 2026 08:13
@KyrylR

KyrylR commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

apoelstra it looks like to get rid of duplicate deps like "bitcoin_hashes", "hex-conservative", miniscript project should be updated to use latest bitcoin crate (though I did not look deep into it)

@KyrylR
KyrylR marked this pull request as draft September 23, 2026 09:12
@KyrylR
KyrylR marked this pull request as ready for review September 23, 2026 09:16
@LesterEvSe

LesterEvSe commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Looks good overall. I found no blocking bugs.

A few small CHANGELOG.md suggestions before merging:

Also non-blocking point from #388: TemplateProgram::instantiate(self, _: Arguments) ignores its argument, because parameters are already applied in compile. Since it becomes public API in 0.8.0, a short doc note saying the argument is currently unused (or making it pub(crate) for now) would avoid confusion.

@apoelstra

Copy link
Copy Markdown
Contributor

miniscript project should be updated to use latest bitcoin crate

We will, eventually. But miniscript is a widely used production project and we are not going to cut a new release lightly.

To deal with hashes and hex in particular we are going to semver-trick those dependencies so that the old versions are compatible with the new.

@apoelstra

Copy link
Copy Markdown
Contributor

Can you please split the rust-simplicty update and the release into separate commits?

@KyrylR

KyrylR commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

Can you please split the rust-simplicty update and the release into separate commits?

Done

@apoelstra

Copy link
Copy Markdown
Contributor

In 77dc04a:

I see there's some fixes from #415 in here, which normally I'd complain about being "unrelated changes", but since I've taken so long to review #415 I'll accept that it's my own fault. (I have run it through my local CI system 3 or 4 times but keep forgetting to investigate the elementsd failures until after they've been garbage collected, sorry..)

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3ff66b2; successfully ran local tests

@KyrylR
KyrylR merged commit 6d93906 into master Sep 26, 2026
12 checks passed
@KyrylR
KyrylR deleted the release/0.8.0 branch September 26, 2026 15:12
@apoelstra

Copy link
Copy Markdown
Contributor

Did this PR have a release in it? Was it tagged and published?

@KyrylR

KyrylR commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, forgot to comment

Tagged and published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants