Repository navigation
Add bitcoin jets - #437
Open
LesterEvSe wants to merge 1 commit into
Open
Add bitcoin jets#437LesterEvSe wants to merge 1 commit into
LesterEvSe wants to merge 1 commit into
Conversation
KyrylR
approved these changes
Oct 9, 2026
KyrylR
left a comment
KyrylR
left a comment
Collaborator
There was a problem hiding this comment.
ACK e2cd9b1; successfully ran local tests
Not sure about putting it under the feature flag, but it is nice to be careful in the beginning
Anyway we can lift it easily later on
Overall the set of jets is unlikely to change, so LGTM
Contributor
|
I think I saw something similar in @delta1 branch somewhere, just a note to not do the double work. |
Collaborator
Author
|
I don't think it's double work: this PR upstreams that work, since @delta1 hasn't opened a PR for it. I took the jets from the PoC branch, which adapted them from delta1's |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Bitcoin jets in preparation for Bitcoin support in SimplicityHL #436, since rust-simplicity already provides all of them
Checklist
examples/kitchen_sink.simf, andtest-data/kitchen_sink.jsonisregenerated.