BL-16822 Book CSS for inline (Word-style) images, and a layout suite for it - #8319
Draft
hatton wants to merge 1 commit into
Draft
BL-16822 Book CSS for inline (Word-style) images, and a layout suite for it#8319hatton wants to merge 1 commit into
hatton wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
…for it The rules that make a picture sit inside a text block with the text flowing around it: the four docks, the width and aspect-ratio custom properties the editor writes, the vertical offset, and the shape-outside that gives the wrap its contour. They live in their own file, src/content/bookLayout/inlineImages.less, because two themes need them and a second copy would drift. basePage-sharedRules.less imports it for the current themes; basePage-legacy-5-6.less imports the same file, because that legacy copy of basePage.css was frozen long before this feature existed and a book using the legacy theme can still contain a picture in its text. This is the part of the feature that lands in published books, so it comes with its own layout suite: bookEdit/inline-images-e2e/ builds pages from the compiled book CSS and measures the wrap geometry directly. Unlike the canvas suite next to it, it needs no running Bloom, which is why it is registered as its own `pnpm e2e inline-images` target and excluded from the vitest globs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014DCBGajN5YyAYPBenEf1yy
hatton
force-pushed
the
BL-16822-inline-1-menu-refactor
branch
from
September 7, 2026 19:41
c3c2161 to
c39d126
Compare
hatton
force-pushed
the
BL-16822-inline-2-book-css
branch
from
September 7, 2026 19:41
ade2a25 to
a2403dd
Compare
Member
Author
|
[Claude Opus 5 (1M context) from Hatton's machine during devin-review] Consulted Devin on 2026-09-07 12:46 MDT up to commit It raised nothing on this PR. The fixes were amended into this branch after the review, so the commit above is not the current head; a fresh review is running against the new one. The only GitHub check on this PR is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rules that make a picture sit inside a text block with the text flowing around
it: the four docks, the width and aspect-ratio custom properties the editor writes,
the vertical offset, and the shape-outside that gives the wrap its contour.
They live in their own file, src/content/bookLayout/inlineImages.less, because two
themes need them and a second copy would drift. basePage-sharedRules.less imports it
for the current themes; basePage-legacy-5-6.less imports the same file, because that
legacy copy of basePage.css was frozen long before this feature existed and a book
using the legacy theme can still contain a picture in its text.
This is the part of the feature that lands in published books, so it comes with its
own layout suite: bookEdit/inline-images-e2e/ builds pages from the compiled book CSS
and measures the wrap geometry directly. Unlike the canvas suite next to it, it needs
no running Bloom, which is why it is registered as its own
pnpm e2e inline-imagestarget and excluded from the vitest globs.
Card: https://issues.bloomlibrary.org/youtrack/issue/BL-16822
🤖 Generated with Claude Code
https://claude.ai/code/session_014DCBGajN5YyAYPBenEf1yy
Devin review
This change is