BL-16818 Tables 3/6: video as a cell content type - #8327
Open
hatton wants to merge 2 commits into
Open
Conversation
Third of six PRs splitting BL-16818. A table cell can now hold a video, the way it already holds text or a picture. tableEditing registers "video" as a content type, so the cell menu offers it, and wires the video container of any cell the library builds after the page has loaded. The sign language tool and bloomVideo learn to work on a container inside a cell rather than assuming the page's own video container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of six stacked PRs splitting #8315. Base is
BL-16818-table-on-canvas(#8326).Small one. A table cell can hold a video, the way it already holds text or a picture.
tableEditingregistersvideoas a content type, so the cell menu offers it, and wires the video container of any cell the library builds after the page has loaded. The sign language tool andbloomVideolearn to work on a container inside a cell rather than assuming the page's own video container.What to try
In a table cell's content menu, choose Video, then record or choose one with the Sign Language tool.
Checks
pnpm typecheckgreen;tableEditing.test.tsandbloomVideo.spec.tspass (8 tests).[Claude Opus 5 following a prompt from Hatton]
Devin review
This change is